mirror of
https://git.notmuchmail.org/git/notmuch
synced 2024-12-27 20:01:42 +01:00
d805866ec5
This is simply 50 messages from the early history of the notmuch mailing list, (fetched from the public archives).
57 lines
2.4 KiB
Text
57 lines
2.4 KiB
Text
From: "Carl Worth" <cworth@cworth.org>
|
|
To: notmuch@notmuchmail.org
|
|
Date: Tue, 17 Nov 2009 09:13:27 -0800
|
|
Subject: [notmuch] [PATCH 1/2] Close message file after parsing message
|
|
headers
|
|
In-Reply-To: <1258471718-6781-1-git-send-email-dottedmag@dottedmag.net>
|
|
References: <1258471718-6781-1-git-send-email-dottedmag@dottedmag.net>
|
|
Message-ID: <87lji5cbwo.fsf@yoom.home.cworth.org>
|
|
|
|
On Tue, 17 Nov 2009 21:28:37 +0600, Mikhail Gusarov <dottedmag at dottedmag.net> wrote:
|
|
> Keeping unused files open helps to see "Too many open files" often.
|
|
>
|
|
> Signed-off-by: Mikhail Gusarov <dottedmag at dottedmag.net>
|
|
...
|
|
On Tue, 17 Nov 2009 21:28:38 +0600, Mikhail Gusarov <dottedmag at dottedmag.net> wrote:
|
|
>
|
|
> Signed-off-by: Mikhail Gusarov <dottedmag at dottedmag.net>
|
|
> ---
|
|
> lib/message.cc | 2 ++
|
|
> 1 files changed, 2 insertions(+), 0 deletions(-)
|
|
|
|
Hi Mikhail,
|
|
|
|
Welcome to notmuch, and thanks for these patches! I've pushed both of
|
|
them out now.
|
|
|
|
Keith ran into the same problem of "too many open files" and wrote a
|
|
more complex fix, (which included what you did here). His code can be
|
|
seen at:
|
|
|
|
git://keithp.com/git/notmuch
|
|
|
|
I didn't apply Keith's fix yet, because I think I'd rather just fix the
|
|
indexer to store the In-Reply-To header in a separate term prefix from
|
|
the term used for the References header[*]. That will then let us lookup
|
|
the in-reply-to value later for thread constructions without having to
|
|
open the original email file at all.
|
|
|
|
-Carl
|
|
|
|
[*] Yes, this is my first post to our new mailing list and I'm already
|
|
spouting off about "terms" and "prefixes" without any definitions. I
|
|
apologize for that. I hope that people will ask questions freely here on
|
|
the list whenever anything is not clear, and I'll be glad to explain
|
|
things as needed. (Then when can shove answers into a HACKING document.)
|
|
|
|
PS. This reply is a great example of a feature that notmuch *almost*
|
|
supports already---repling to multiple messages at once. The "notmuch
|
|
reply" command line does everything necessary to make this work, but we
|
|
haven't yet hooked up any keybindings for this in the emacs client yet.
|
|
Obviously, 'r' from the search view could reply to the entire thread.
|
|
But when viewing a thread, anyone have a good keybinding suggestion?
|
|
(There's obviously 'R' as opposed to 'r', but I think we'll probably
|
|
want to distinguish "reply to sender" from "reply to all" before trying
|
|
to distinguish "reply to message" from "reply to thread" (which I
|
|
imagine is more rare of an operation).
|
|
|