mirror of
https://git.notmuchmail.org/git/notmuch
synced 2024-11-25 12:28:09 +01:00
e7ade21d56
For such a simple regexp, this was broken in a very complicated way. The intent was to strip the newline (and potentially other whitespace) off the end of the error string so there wasn't an extra newline in the error signal. However, the regexp was deeply dependent on the active syntax table and the subtleties of $. We didn't notice this because all notmuch major modes put ?\n in the whitespace class, which makes this behaved as intended: the "\\s " matches all newlines, but by matching the newline character, causes the $ *not* to match *except* where it matched the empty string at the very end of the string, which was not followed by a newline. However, if the syntax table declares ?\n to be non-whitespace (lisp-mode declares it as endcomment, and is likely to be the mode you're in when testing functions), then this regexp behaves completely differently, matching trailing spaces at the end of every line within the string. The solution is to say what we mean for whitespace *and* to switch from $ to \', which matches only the end of the string, rather than the end of each line. Both are necessary or this will strip away interior newlines, which is not what we want. |
||
|---|---|---|
| .. | ||
| coolj.el | ||
| make-deps.el | ||
| Makefile | ||
| Makefile.local | ||
| notmuch-address.el | ||
| notmuch-crypto.el | ||
| notmuch-hello.el | ||
| notmuch-lib.el | ||
| notmuch-logo.png | ||
| notmuch-maildir-fcc.el | ||
| notmuch-message.el | ||
| notmuch-mua.el | ||
| notmuch-print.el | ||
| notmuch-query.el | ||
| notmuch-show.el | ||
| notmuch-tag.el | ||
| notmuch-wash.el | ||
| notmuch.el | ||
