notmuch/emacs
Jonas Bernoulli f47e3333b5 emacs: avoid unnecessary let-bindings
To some extend this is a personal preference, but the preference is
strongly dependent on whether one is used to a language that makes it
necessary to use variables like this.

This makes it perfectly clear that we are first getting and then using
a "foo":

  (use-foo (get-foo))

Sure this has to be read "inside out", but that's something one better
gets used to quickly when dealing with lisp.  I don't understand why
one would want to write this instead:

  (let ((the-foo (get-foo)))
    (use-foo the-foo))

Both `get-foo' and `use-foo' are named in a way that make it very
clear that we are dealing with a "foo".  Storing the value in an
additional variable `the-foo' does not make this any more clear.

On the contrary I makes the reader wonder why the author choose to
use a variable.  Is the value used more than once?  Is the value
being retrieved in one context and then used in another (e.g. when
the current buffer changes)?
2021-01-15 06:45:30 -04:00
..
.gitignore emacs: build docstring (rsti) files 2018-12-08 08:49:31 -04:00
coolj.el emacs: use lexical-bindings in all libraries 2021-01-13 07:16:04 -04:00
make-deps.el emacs: use lexical-bindings in all libraries 2021-01-13 07:16:04 -04:00
Makefile fix sum moar typos [build scripts, Makefiles] 2011-06-23 15:44:59 -07:00
Makefile.local emacs: Use makefile-gmake-mode in Makefile*s 2020-08-09 21:14:36 -03:00
notmuch-address.el emacs: avoid unnecessary let-bindings 2021-01-15 06:45:30 -04:00
notmuch-company.el emacs: make headings outline-minor-mode compatible 2021-01-13 07:10:27 -04:00
notmuch-compat.el emacs: use lexical-bindings in all libraries 2021-01-13 07:16:04 -04:00
notmuch-crypto.el emacs: notmuch-crypto-status-button-type: fix potential bug 2021-01-13 07:23:11 -04:00
notmuch-draft.el emacs: various doc-string improvements 2021-01-15 06:40:58 -04:00
notmuch-emacs-mua notmuch-emacs-mua: add --hello parameter 2016-11-26 08:15:11 -04:00
notmuch-emacs-mua.desktop emacs: add keywords to notmuch-emacs-mua.desktop 2019-06-29 21:06:18 +02:00
notmuch-hello.el emacs: various comment improvements 2021-01-15 06:38:43 -04:00
notmuch-jump.el emacs: various cosmetic improvements 2021-01-15 06:38:00 -04:00
notmuch-lib.el emacs: avoid unnecessary let-bindings 2021-01-15 06:45:30 -04:00
notmuch-logo.png emacs: Add notmuch-hello.el, a friendly frontend to notmuch 2010-04-23 12:50:18 -07:00
notmuch-maildir-fcc.el emacs: avoid unnecessary let-bindings 2021-01-15 06:45:30 -04:00
notmuch-message.el emacs: notmuch-message-apply-queued-tag-changes: cosmetics 2021-01-13 07:23:11 -04:00
notmuch-mua.el emacs: various doc-string improvements 2021-01-15 06:40:58 -04:00
notmuch-parser.el emacs: inline notmuch-sexp-eof into only caller 2021-01-13 07:17:25 -04:00
notmuch-pkg.el.tmpl NEWS: At least Emacs 25.1 is required now 2020-08-09 21:14:36 -03:00
notmuch-print.el emacs: deal with unused lexical arguments and variables 2021-01-13 07:16:23 -04:00
notmuch-query.el emacs: various cosmetic improvements 2021-01-15 06:38:00 -04:00
notmuch-show.el emacs: avoid unnecessary let-bindings 2021-01-15 06:45:30 -04:00
notmuch-tag.el emacs: avoid unnecessary let-bindings 2021-01-15 06:45:30 -04:00
notmuch-tree.el emacs: avoid unnecessary let-bindings 2021-01-15 06:45:30 -04:00
notmuch-version.el.tmpl emacs: Increase consistency of library headers 2020-08-09 21:14:36 -03:00
notmuch-wash.el emacs: notmuch-wash.el: require diff-mode at beginning of code 2021-01-13 07:23:11 -04:00
notmuch.el emacs: avoid unnecessary let-bindings 2021-01-15 06:45:30 -04:00
rstdoc.el emacs: use lexical-bindings in all libraries 2021-01-13 07:16:04 -04:00
rstdoc.rsti emacs: initial version of rstdoc.el 2018-12-08 08:45:48 -04:00