notmuch.el: Don't advance line in search buffer before showing thread.

Previously, when selecting a thread to view from the search buffer, we
would advance the point by one line before showing the thread, (so
that it would be ready to show the next thread once the user was done
with the current thread). This was annoying when the user temporarily
exited the thread view, (because the "wrong" thread was then selected
in the search view).

We get a more consistent experience by waiting to advance until the
user has finished viewing one thread and is ready to view the next.
This commit is contained in:
Carl Worth 2009-11-09 13:48:58 -08:00
parent 97ef8a74c9
commit 8ae1c3c6e1

View file

@ -184,6 +184,7 @@ Unlike builtin `next-line' this version accepts no arguments."
(if parent-buffer (if parent-buffer
(progn (progn
(switch-to-buffer parent-buffer) (switch-to-buffer parent-buffer)
(forward-line)
(notmuch-search-show-thread))))) (notmuch-search-show-thread)))))
(defun notmuch-show-mark-read-then-archive-thread () (defun notmuch-show-mark-read-then-archive-thread ()
@ -713,7 +714,6 @@ global search.
(defun notmuch-search-show-thread () (defun notmuch-search-show-thread ()
(interactive) (interactive)
(let ((thread-id (notmuch-search-find-thread-id))) (let ((thread-id (notmuch-search-find-thread-id)))
(forward-line)
(if (> (length thread-id) 0) (if (> (length thread-id) 0)
(notmuch-show thread-id (current-buffer)) (notmuch-show thread-id (current-buffer))
(error "End of search results")))) (error "End of search results"))))