debian/notmuch
1
0
Fork 0
mirror of https://git.notmuchmail.org/git/notmuch synced 2024-12-23 01:44:52 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

emacs: Remove over-eager regular expressions from notmuch-wash-tidy-citations.

Browse source 
The removed expressions, which were used to ensure that citations were
both preceded and followed by a blank line, were poorly implemented
and caused a regexp stack overflow on messages more than a few
thousand lines long.
This commit is contained in:
David Edmondson 2010-11-17 13:32:33 +00:00 committed by Carl Worth
parent 5d05d5434d
commit b9d4af4641
1 changed files with 2 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
emacs/notmuch-wash.el
View file

@ -190,7 +190,7 @@ is what to put on the button."
(defun notmuch-wash-tidy-citations (depth) (defun notmuch-wash-tidy-citations (depth)
"Improve the display of cited regions of a message. "Improve the display of cited regions of a message.
Perform four transformations on the message body: Perform several transformations on the message body:
- Remove lines of repeated citation leaders with no other - Remove lines of repeated citation leaders with no other
content, content,
@ -214,17 +214,7 @@ Perform four transformations on the message body:
;; text. ;; text.
(goto-char (point-min)) (goto-char (point-min))
(while (re-search-forward "\\(^>[> ]*\n\\)\\(^$\\|^[^>].*\\)" nil t) (while (re-search-forward "\\(^>[> ]*\n\\)\\(^$\\|^[^>].*\\)" nil t)
(replace-match "\\2")) (replace-match "\\2")))
;; Insert a blank line before a citation if there isn't one.
(goto-char (point-min))
(while (re-search-forward "\\(^[^>]+\\)\n>" nil t)
(replace-match "\\1\n\n>"))
;; Insert a blank line after a citation if there isn't one.
(goto-char (point-min))
(while (re-search-forward "\\(^>.+\\)\n\\([^>]\\)" nil t)
(replace-match "\\1\n\n\\2")))
;; ;;