David Bremner
49d630d0f3
bindings/ruby: replacy use of deprecated notmuch_message_get_flag
...
Depending on the flag, this actually can return an errror, so raise a
ruby exception if so.
2020-07-18 11:03:29 -03:00
David Bremner
c8539d5e92
lib/thread: replace use of deprecated notmuch_message_get_flag
...
This adds one more reason why _notmuch_thread_create might return
NULL, but those were not previously enumerated, so no promises are
broken.
2020-07-18 11:03:29 -03:00
David Bremner
a4776faa9b
lib/add-message: drop use of deprecated notmuch_message_get_flag.
...
As a side effect, we revert the switch from notmuch_bool_t to bool
here. This is because those two types are not actually compatible when
passing by reference.
2020-07-18 11:03:28 -03:00
David Bremner
ef27194a93
cli/show: replace deprecated notmuch_message_get_flag
...
This can be seen as moving an abort out of the library, into the CLI
where we can both print to stderr and shut the process down without
ill effect.
2020-07-18 11:03:28 -03:00
David Bremner
c76832a203
cli/search: replace deprecated notmuch_message_get_flag
...
Our handling of errors is all or nothing here, but it's an improvement
on the status quo, and it avoids rippling internal API changes.
2020-07-18 11:03:28 -03:00
David Bremner
2d04ed2631
lib: catch exceptions in n_m_get_flag, provide n_m_get_flag_st
...
It's not very nice to return FALSE for an error, so provide
notmuch_message_get_flag_st as a migration path.
Bump LIBNOTMUCH_MINOR_VERSION because the API is extended.
2020-07-18 09:52:27 -03:00
David Bremner
13116c5ced
configure: make sure WITH_PYTHON_DOCS is initialized
...
Thanks to pazz for reporting the problem.
2020-07-16 15:59:45 -03:00
David Bremner
a05da45523
doc: add new python bindings to main documentation tree.
...
A separate conf.py and doc directory (or will be needed if someone wants
to build the bindings docs separately from notmuch.
2020-07-15 08:37:11 -03:00
David Bremner
0e03e2d45e
doc: replace use of environment variables with a generated config
...
It is getting unwieldy to pass configuration options on the
sphinx-build command line, and I anticipate further use of
conditionals.
As far as I could tell, execing a string is the idiomatic way to
emulate include in Python.
2020-07-15 08:32:15 -03:00
David Bremner
78e9b3467d
lib: use COERCE_STATUS in n_m_{add,remove}_tag
...
Currently I don't know of a good way of testing this, but at least in
principle a Xapian exception in _notmuch_message_{add,remove}_term
would cause an abort in the library.
2020-07-14 07:31:45 -03:00
David Bremner
aa8e3f4487
lib: catch Xapian exceptions in n_m_remove_tag
...
The churn here is again mainly re-indentation.
2020-07-14 07:31:45 -03:00
David Bremner
0fc769aa4f
test: add broken test for n_m_remove_tag
...
Exception will be caught in next commit.
2020-07-14 07:31:45 -03:00
David Bremner
33dd5fdc69
lib: catch Xapian exceptions in n_m_add_tag
...
This is mostly just (horizontal) code movement due to wrapping
everything in a try / catch.
2020-07-14 07:31:45 -03:00
David Bremner
503c035077
test: add known broken test for n_m_add_tag with closed db
...
Exception will be caught in next commit.
2020-07-14 07:31:45 -03:00
David Bremner
96befd0dd0
lib: catch Xapian exceptions in n_m_count_files
...
This will require some care for the caller to check the sign, and not
just add error returns into a running total.
2020-07-14 07:31:37 -03:00
David Bremner
6dc62d8bea
test: add known broken test for n_m_count_files
...
This will be fixed in the next commit.
2020-07-14 07:31:30 -03:00
David Bremner
00f1abfdf4
lib: catch Xapian exceptions in n_m_get_tags
...
This allows the function to return an error value rather than
crashing.
2020-07-14 07:12:52 -03:00
David Bremner
d284dc00da
test: add known broken test for n_m_get_tags
...
This will be fixed in the next commit.
2020-07-14 07:12:52 -03:00
David Bremner
e404d8a51d
lib: use LOG_XAPIAN_EXCEPTION in n_m_get_date
...
This should not change functionality, but does slightly reduce code
duplication. Perhaps more importantly it allows consistent changes to
all of the similar exception handling in message.cc.
2020-07-14 07:12:52 -03:00
David Bremner
6eaadb43ad
lib: add regression test for n_m_get_date; clarify API
...
This function catches Xapian exceptions. The test is intended to make
sure it stays that way.
2020-07-14 07:12:52 -03:00
David Bremner
ef15946def
test: add known broken for n_m_get_flag on closed db
...
Exception caught in next commit. Note that FLAG_GHOST is the only one
that triggers the I/O code path.
2020-07-13 07:19:22 -03:00
David Bremner
286161b703
lib: catch exceptions in n_m_get_filenames
...
This is essentially copied from the change to notmuch_message_get_filename
2020-07-13 07:19:22 -03:00
David Bremner
2c2ba7d6e2
test: add known broken test for n_m_get_filenames
...
This will be fixed in the next commit
2020-07-13 07:19:22 -03:00
David Bremner
a606cba32b
lib/n_m_g_filename: catch Xapian exceptions, document NULL return
...
This is the same machinery as applied for
notmuch_message_get_{thread,message}_id
2020-07-13 07:19:22 -03:00
David Bremner
46e8076281
lib: add known broken test for notmuch_message_get_filename
...
This will be fixed in the next commit
2020-07-13 07:19:22 -03:00
David Bremner
a962bd2bf8
lib/n_m_get_replies: doc return, initial regression test
...
We need to to set a query and retrieve the threads to meaningfully
test this function.
2020-07-13 07:19:22 -03:00
David Bremner
056794a60d
test: add regression test for n_m_get_header
...
This function already catches Xapian exceptions, and we want to make
sure it stays that way.
2020-07-13 07:19:22 -03:00
David Bremner
9201c50204
lib/message: use LOG_XAPIAN_EXCEPTION in n_m_get_header
...
This is just for consistency, and a small reduction in the amount of
boilerplate.
2020-07-13 07:19:22 -03:00
David Bremner
cca551a736
test: drop use of assert in closed db tests
...
Instead of printing the same static string for each test, can replace
the assert with something simpler (or at least easier to integrate
into the test suite).
2020-07-13 07:19:22 -03:00
David Bremner
a280d2a1a1
test: remove unused backup_database calls
...
Since these backups are never restored, they should be safe to remove.
2020-07-13 07:19:22 -03:00
David Bremner
30e43c7c27
debian: drop ValueRangeProcessor symbols
...
These are not used since b90d852
2020-07-11 19:52:21 -03:00
David Bremner
ee897cab8b
test: drop upgrade from v1 tests
...
These are less crucial since we stopped generating new database
versions and relied primarily on features. They also rely on a
pre-generated v1 database which happens to be chert format. This
backend is not supported by Xapian 1.5.
Also drop the tool gen-testdb.sh, which is currently broken, due to
changes in the testing infrastructure.
2020-07-11 17:20:09 -03:00
David Bremner
b90d852a2f
lib: migrate from Xapian ValueRangeProcessor to RangeProcessor
...
This will be mandatory as of Xapian 1.5. The API is also more
consistent with the FieldProcessor API, which helps code re-use a bit.
Note that this switches to using the built-in Xapian support for
prefixes on ranges (i.e. deleted code at beginning of
ParseTimeRangeProcessor::operator(), added prefix to constructor).
Another side effect of the migration is that we are generating smaller
queries, using one OP_VALUE_RANGE instead of an AND of two OP_VALUE_*
queries.
2020-07-11 17:20:09 -03:00
David Bremner
a1b7cc834b
lib: migrate to post Xapian 1.3.4 compact support
...
The old API was deprecated in Xapian 1.3.4 and (will be) removed in 1.5.0
2020-07-11 17:20:09 -03:00
Jonas Witschel
a962842d9b
doc: make gzipped man pages reproducible
...
gzip includes the name of the uncompressed file and its modification
timestamp into the compressed archive. The latter makes it hard to
reproduce the generated files bit for bit at a later time, so omit this
information from the archive using the "--no-name" option. This is a
reproducibility best practice, see
https://wiki.debian.org/ReproducibleBuilds/TimestampsInGzipHeaders
2020-07-11 13:57:17 -03:00
David Bremner
5fbb2c7929
Merge branch 'release'
2020-07-10 23:24:41 -03:00
David Bremner
b502e26563
NEWS: update date for release
2020-07-10 22:25:04 -03:00
David Bremner
fbc341f712
debian: changelog for 0.30
2020-07-10 22:24:41 -03:00
David Bremner
e56a207ce1
version: set to 0.30
2020-07-10 22:21:19 -03:00
David Bremner
dbdb860bb9
lib/message: catch exception in n_m_get_thread_id
...
This allows us to return an error value from the library.
2020-07-03 21:04:43 -03:00
David Bremner
bb51f3aa29
test: add known broken test for n_m_get_thread_id on closed db
...
This will be fixed in the next commit.
2020-07-03 21:04:02 -03:00
David Bremner
87d462a204
lib: catch error from closed db in n_m_get_message_id
...
By catching it at the library top level, we can return an error value.
2020-07-03 21:03:51 -03:00
David Bremner
2c17327ee5
test: add known broken test for error handling on closed database
...
Based on id:87d05je1j6.fsf@powell.devork.be
2020-07-03 21:01:39 -03:00
David Bremner
552029f748
build: produce signatures for release candidate tarballs.
...
Today Defalos on #notmuch asked for a signed tarball for
0.30~rc2. This is a minimal change to support this in the future. The
question of automagically uploading will need more thought; currently
I like the fact that tags from pre-releases are only pushed manually.
2020-07-03 07:37:00 -03:00
David Bremner
e9f8ffd882
test: fix python 3.8.4 related regression in T210-raw
...
It seems (at least in 3.8.4~rc1-1 on Debian) that set_content requires
at least one line.
2020-07-03 07:23:32 -03:00
David Bremner
4539d68e3b
debian: changelog fo 0.30~rc3-1
2020-07-03 06:50:16 -03:00
David Bremner
038b3e7c30
version: bump to 0.30~rc3
2020-07-03 06:45:17 -03:00
David Bremner
3a42abb456
bindings/python-cffi: copy version file into bindings dir
...
Attempt to avoid breaking "pip install ."
As far as I can tell, we need to have a copy (not just a relative
symlink) of the version file.
2020-07-03 06:38:55 -03:00
David Bremner
f981f5bae0
doc: update install suggestions for fedora derivatives
...
Fedora still has an old gmime-devel which is 2.6.x. This is no longer
supported by notmuch. Also apparently dnf is a better choice than yum.
2020-07-03 06:31:54 -03:00
Daniel Kahn Gillmor
18a1522948
tests: mark sig verification known-broken with session keys on buggy gpgme
...
We make use of the just-introduced configure test.
Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
2020-07-02 21:23:28 -03:00