debian/notmuch
1
0
Fork 0
mirror of https://git.notmuchmail.org/git/notmuch synced 2024-11-22 19:08:09 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
5336 commits 14 branches 412 tags 12 MiB
Commit graph

5336 commits

This branch
This branch
All branches
Author SHA1 Message Date
David Bremner
75916f1cc2 NEWS: start entry for 0.25 2017-07-16 08:02:51 -03:00
David Bremner
694e443db5 version: bump version to 0.25~rc0 2017-07-16 08:01:42 -03:00
David Bremner
edb933b25d crypto: clean up unused definitions in gmime 3.0 
based on the same patch from dkg as the previous commit.
 2017-07-15 21:43:39 -03:00
David Bremner
66c9b11bb0 crypto: Avoid explicit handling of GMimeCryptoContext in gmime 3 
gmime 3.0 knows how to select the correct GMimeCryptoContext
automatically, so a bunch of the code in notmuch can be dropped in
that case.

The #ifdef removal of the crypto stuff is better than #define aliasing
in gmime-extra.h for this stuff.  When built against gmime 3.0:

    * it reduces compiled code, and
    * it avoids initializing unused gpgme contexts

(based on a patch from dkg)
 2017-07-15 21:43:08 -03:00
David Bremner
606e320e47 cli/crypto: eliminated compiler warnings about unused arguments 
These are due to (excessively?) fancy macro definitions in gmime-extra.h
 2017-07-15 21:42:49 -03:00
David Bremner
1fdc08d0ff cli/crypto: treat failure to create a crypto context as fatal. 
Silently ignoring signed/encrypted parts seems like the wrong idea,
and it also complicates future gmime-3.0 compatibility changes.
 2017-07-15 21:39:37 -03:00
David Bremner
f1bcb6b7c2 emacs: change default for notmuch-crypto-process-mime to t 
There are some cases like remote usage where this might cause
problems, but those users can easily customize the variable. The
inconvenience seems to be outweighed by the security benefit for most
users.
 2017-07-15 09:11:32 -03:00
Tomi Ollila
9fd48b78d0 NEWS: a few formatting updates for 0.24 news items (wiki compatibility) 
- removed 7 trailing dots -- to make those lines subsection headers

- converted some (mime type) text to monospace

- removed one extra space
 2017-07-15 09:07:17 -03:00
Daniel Kahn Gillmor
f76a245009 clean up use of constants in g_mime_multipart_ wrappers 
When compiling as C code (instead of C++) against gmime 3.0, gcc gives
errors like the following:

    error: invalid conversion from ‘int’ to ‘GMimeDecryptFlags’ [-fpermissive]

so use explicit *_NONE values instead.
 2017-07-14 21:23:52 -03:00
Daniel Kahn Gillmor
e142de643d config: deprecate/drop crypto.gpg_path under gmime 2.6/3.0 
gmime 3.0 no longer offers a means to set the path for gpg.

Users can set $PATH anyway if they want to pick a
differently-installed gpg (e.g. /usr/local/bin/gpg), so this isn't
much of a reduction in functionality.

The one main difference is for people who have tried to use "gpg2" to
make use of gpg 2.1, but that isn't usefully co-installable anyway.
 2017-07-14 21:23:52 -03:00
Daniel Kahn Gillmor
8492298a61 Add additional munged reply-to tests 
The reply-to munging code might behave differently whether there's an
exact match on the strings or not, or whether the string is a raw
addr-spec instead of an name-addr.  These tests cover those variations
(i also had to tweak json output further below when this new test was
added).
 2017-07-14 21:23:52 -03:00
Daniel Kahn Gillmor
23a4d09773 Ensure that "notmuch reply" succeeds during testing. 
In some (bad!) cases, "notmuch reply" might fail, or might even
segfault.  If this happens, it indicates a bug, and the test suite
should notice it.
 2017-07-14 21:23:52 -03:00
David Bremner
cd853915ec cli: wrap getting uid 
Apparently it moved from "name" to "key_id" in gmime-3.0
 2017-07-14 21:23:52 -03:00
David Bremner
2b3224a6c4 cli: make keyid from fingerprint in gmime 3.0 
The "key_id" field seems to used for userid in gmime-3.0, while the
keyid is dropped in the fingerprint field if the full fingerprint is
not available.
 2017-07-14 21:23:52 -03:00
David Bremner
4ce7591610 lib: paper over allocation difference 
In gmime 3.0 this function is "transfer none", so no deallocation is
needed (or permitted)
 2017-07-14 21:23:52 -03:00
David Bremner
eeb64cdeeb lib: add version of _n_m_f_get_combinded_header for gmime 3.0 
The iterator is gone, so we need a new loop structure.
 2017-07-14 21:23:52 -03:00
David Bremner
439c5896b6 lib: refactor _notmuch_messsage_file_get_combined_header 
We need to rewrite the loop for gmime-3.0; move the loop body to its
own function to avoid code duplication.  Keep the common exit via
"goto DONE" to make this pure code movement.  It's important to note
that the existing exit path only deallocates the iterator.
 2017-07-14 21:23:52 -03:00
David Bremner
c040464a7c lib: wrap use of g_mime_utils_header_decode_date 
This changes return type in gmime 3.0
 2017-07-14 21:23:52 -03:00
David Bremner
fd6e4a9953 cli: hide rename of GMimeCertificateTrust 
Both the enum and the values are renamed in GMime 3.0.
 2017-07-14 21:23:52 -03:00
David Bremner
c7b9bdb81e cli: generalize use of GMIME_SIGNATURE_{ERROR,STATUS} to gmime-3 
The ERROR enum is merged into to the STATUS enum, and the set of flags
is different.
 2017-07-14 21:23:52 -03:00
David Bremner
f4a989484f util: fake gmime-2.6 compatible API for gmime-3.0 
Several functions have added arguments which accept NULL and provide
hopefully sensible defaults. Use macros to minimize source changes.
 2017-07-14 17:58:09 -03:00
David Bremner
32819f74d3 cli: replace use of g_mime_message_get_recipients 
This function, and associated enum, have been renamed and generalized
in gmime-3.0.
 2017-07-14 17:58:09 -03:00
David Bremner
cbb2d5608e lib/cli: replace use of g_mime_message_get_sender 
This function changes semantics in gmime-3.0 so make a new function
that provides the same functionality in both
 2017-07-14 17:58:09 -03:00
David Bremner
d7fea36916 cli: replace use of g_mime_message_get_reply_to 
This function changes signature in gmime 3.0, so we provide two new
functions, one for each signature.
 2017-07-14 17:58:09 -03:00
David Bremner
67dbd24ece cli: replace use of g_mime_message_get_date_as_string 
This function goes away in gmime-3.0. Also, the memory management is
apparently error prone, witness the memory leak in notmuch-reply.
 2017-07-14 17:58:09 -03:00
David Bremner
a58c75fdf6 test/crypto: mark extra space in userid as a bug in gmime-2.6 
I can't see the space in the output of gpg -K --with-colons
 2017-07-14 17:58:09 -03:00
David Bremner
a32dd81a55 cli: add space separator for keyword, string, and int arguments 
Defer the complication of optional boolean arguments for later (never?).
 2017-07-12 17:46:29 -03:00
David Bremner
de9baa29dc cli: change api of parse_option 
The idea is to allow it (in a future commit) advance to the next argv
element to get a value
 2017-07-12 17:44:15 -03:00
David Bremner
15815d4e4c cli/show: convert keyword options to booleans 
There are two keyword options here that impliment boolean options. It
is simpler to use the built-in boolean argument handling, and also
more robust against divergence in parsing boolean and keyword arguments.
 2017-07-12 17:42:23 -03:00
Kyle Meyer
37d1fa5672 emacs: tree: drop repeated "of" from docstring 2017-07-10 21:58:30 -03:00
David Bremner
6a79229737 debian: drop notmuch-dbg 
notmuch-dbgsym should be auto generated now.
 2017-07-06 09:21:14 -03:00
David Bremner
87ca29b7a7 test/crypto: add test for corrupted signatures 
Have an empty list of signatures is not the nicest mechanism to signal
complete failure to verify, but it's the one we currently have.
 2017-07-05 07:36:20 -03:00
David Bremner
4f48ae4a5f test: add test for modified pgp/mime signed message 
This is a good thing to test in any case, but particularly as we hit
the dark corners of the gmime crypto API.
 2017-07-05 07:36:20 -03:00
David Bremner
71f04b9a67 test: mark test as broken in gmime 3.0 
Currently I'm not sure what the intent of this test is, so it's not
clear if the new answer is better or worse than the old one.
 2017-07-05 07:13:02 -03:00
David Bremner
f7dd69d4c6 test: mark inclusion of headers as broken in gmime-2.x 
The output of headers here reflects an underlying bug / quirk of
gmime-2.6.
 2017-07-05 07:12:20 -03:00
David Bremner
3805898e3e test/multipart: reorganize creation of multipart message 
We want to have the bodies of the multipart available in a file on
their own for planned modifications to tests.
 2017-07-05 07:12:08 -03:00
David Bremner
e1b7d32db0 cli: implement structured output version 4 
Since the error field is unused by the emacs front end, no changes are
needed other than bumping the format version number.

As it is, this is a bit overengineered, but it will reduce duplication
when we support gmime 3.0
 2017-07-04 08:32:44 -03:00
David Bremner
9eacd7d367 devel/schemata: describe version 4 
Replace numeric errors with human readable flags.  Not all sig_error
keys will necessarily be generated with a given version of gmime.

Drop status "none" as it's currrently unused and I don't know what
it's for.
 2017-07-04 08:32:37 -03:00
David Bremner
b6f87c3085 emacs: convert to use format-version 3 
Keeping the emacs interface running old format-versions makes it
impossible to test new format-versions or deprecate old ones.
 2017-07-04 08:32:28 -03:00
David Bremner
0aba694c11 Merge branch 'release' 2017-07-03 21:35:05 -03:00
David Bremner
1970981bf1 debian: upload 0.24.2-2 
Just a no-change rebuild.
 2017-07-02 12:49:06 -03:00
David Bremner
ab02265777 Merge branch 'debian' 
merge in changes from 0.23.7-3 debian upload
 2017-07-02 10:50:17 -03:00
David Bremner
6dd00d6486 lib/index: add simple html filter 
The filter just drops all (HTML) tags. As an enabling change, pass the
content type to the filter constructor so we can decide which scanner
to user.
 2017-07-01 12:32:27 -03:00
David Bremner
64f81f95a1 lib/index.cc: generalize filter state machine 
To match things more complicated than fixed strings, we need states
with multiple out arrows.
 2017-07-01 12:32:17 -03:00
David Bremner
4a085a5137 lib/index: separate state table definition from scanner. 
We want to reuse the scanner definition with a different table.  This
is mainly code movement, and making the state table part of the filter
struct/class.
 2017-07-01 12:32:03 -03:00
David Bremner
20c15bc820 lib/index: generalize name of indexing filter 
In followup commits we will generalize the functionality of this
filter to deal with other types of non-indexable content.
 2017-07-01 12:31:55 -03:00
Tom Hinton
d848d4040a Fix minor mistake where indentation width is ignored 2017-06-30 08:55:16 -03:00
Damien Cassou
3840b6b495 Add indentation to imenu in notmuch-show 2017-06-30 08:33:29 -03:00
Piotr Trojanek
c9deb32933 remove extra space in Emacs prompt 
Trivial: fix extra space in the "Insert failed" Emacs prompt message.
 2017-06-25 09:57:48 -03:00
Piotr Trojanek
85c8304058 fix wrong printf formatting of signed/unsigned integers 2017-06-25 09:39:35 -03:00