Commit graph

5359 commits

Author SHA1 Message Date
David Bremner
b8ccfe342d version: bump to 0.25~rc1 2017-07-18 07:04:29 -03:00
David Bremner
33e7441fb8 debian: allow emacs25 as a build depend
It's a bit crazy to require emacs 24 installed just to build, when it
isn't required to run.
2017-07-18 06:57:39 -03:00
David Bremner
1d82110f83 emacs: convert remaining format-versions from 3 to 4
This is needed for consistent beheviour between notmuch built against
gmime-2.6 and gmime-3.0 w.r.t. error reporting.
2017-07-18 06:57:26 -03:00
Daniel Kahn Gillmor
d55fffffd7 fix the generated documentation output 2017-07-18 06:53:57 -03:00
Daniel Kahn Gillmor
87bdfbc91f Fix orthography 2017-07-18 06:50:44 -03:00
Daniel Kahn Gillmor
f0b91832c2 use modern debian/copyright 2017-07-18 06:46:02 -03:00
Daniel Kahn Gillmor
02b19c3193 avoid false lintian warning about "iff" 2017-07-18 06:45:18 -03:00
Daniel Kahn Gillmor
5b6d1d720e resolve lintian tag debhelper-but-no-misc-depends notmuch-emacs
This is likely not strictly necessary given that notmuch-emacs is a
transitional package.  But having a simple consistency until we
eventually remove the transitional notmuch-emacs package seems ok too,
and fewer arbitrary lintian warnings will make real lintian warnings
more visible.
2017-07-18 06:44:10 -03:00
Daniel Kahn Gillmor
c3e282fb9b fix Python capitalization 2017-07-18 06:43:18 -03:00
Daniel Kahn Gillmor
19e3089211 explicitly mark notmuch-emacs as transitional 2017-07-18 06:42:32 -03:00
Daniel Kahn Gillmor
44914dc60e Bump standards version to 4.0.0 (no changes needed)
Some things that might be interesting (and are acceptable and
supported under 4.0.0, though not required) are:

 * supporting DEB_BUILD_OPTIONS tag nodoc wihle tagging build-deps (we
   could put python-sphinx into <!nodoc>, for example)

 * splitting out Build-Depends-Arch from Build-Depends
2017-07-18 06:42:07 -03:00
Daniel Kahn Gillmor
be381073c0 Drop duplicate Section header for notmuch-vim
Resolves lintian binary-control-field-duplicates-source
2017-07-18 06:40:52 -03:00
David Bremner
4765590c6d NEWS: drop redundant mention of dump fix
This actually happened in 0.24.x.
2017-07-18 06:36:31 -03:00
David Bremner
4c6e3d83fb uploaded to experimental
-----BEGIN PGP SIGNATURE-----
 
 iQGzBAABCAAdFiEE3VS2dnyDRXKVCQCp8gKXHaSnniwFAllsqxEACgkQ8gKXHaSn
 niwuOwv/QXqdRMfxpztcrOBFJi0HBzm6MB9dJiq6u8S738mYrLy8th16OAuI48ol
 6S/3g9CBAkMhUcg0CguIE7F2x/8w4IweMS7daBk0xhwzdzb5GczmDbgiIfvFG5v6
 PCiqFeqqc3fbhQ583KzvJOQRhRCGkR4qOpkyt3Ho8n4bkXOVawKzOs6+dsWc0X4/
 Xx8n+DZmCU1EOfZkOHCM2yU0Y7H7Hf//ZYbuttJ8gMEYzT0TqCDRNv6mrAoIEXso
 0z+yWYNhhJGqO5xVnCFf6hIxYXJ6TZam32bPkpuNK00OrEKouRQsmJ47d/0L8E17
 fCO9itYdIVKpOHMyKwY0brL+4p8quCz9xexbjeierMPM5MnqvBpR3KAfAyhC8HSH
 K2mZOLP4To1T1uV6ndSwxOec4WHYWfOWXR4FjjGGd/7hDmPGN4W0xsSC5QHeKJd2
 wGcK82Bz+2Hs55xiE4rhfW7IE7Nu0oQluVcI9bbuPu/Zh7ow8hfD6Pu31cZkMuxl
 /KOpFde4
 =W2A/
 -----END PGP SIGNATURE-----

Merge tag 'debian/0.25_rc0-2'

merge 32 bit compilation fix
2017-07-17 09:20:10 -03:00
David Bremner
3891036eee debian: changelog stanza for 0.25~rc0-2 2017-07-17 08:50:08 -03:00
David Bremner
d2c3a0a3a8 util: make g_mime_utils_header_decode_date_unix match prototype
The problem shows up on 32 bit architectures where sizeof(time_t) !=
sizeof(gint64).  Upcasting the 32 bit time_t to a 64 bit integer
should hopefully be safe.
2017-07-17 08:47:18 -03:00
David Bremner
470f74d401 NEWS: Initial writeup for my contributions to 0.25 2017-07-16 22:43:11 -03:00
David Bremner
6e1cc3986d notmuch 0.25~rc0 release
-----BEGIN PGP SIGNATURE-----
 
 iQGzBAABCAAdFiEE3VS2dnyDRXKVCQCp8gKXHaSnniwFAllrU1QACgkQ8gKXHaSn
 niy/pAwAjJrxW+nuTdgcZg6pTvhajHHlRFNGEH1hU4UlYzUVoYAjdkGOURhOXCTj
 zXbIJ07FLrdUtsmBqTZIc1yeiN5y0D2CM7M2hYBXH8UPaXhDJEODgrZmGu5yvFxw
 2i8Fxp9sMkZXznsfvk9KJgYKHT0jbfAojKUv8pEUyI9bmxqLXdYwqCP3weiTJHmQ
 8q0T5V2Kp37JuWoZkanWKT/kMmjXCB+uFOvWKXRsfB6Zh8f8/cNikjHizRhHDHCF
 bev4kdyXwSFMwrCNy/pu6N7bg7PSGISE1Q3CGV/3B/N+D+RHp2mzmSzR5/swc6Qr
 QA6AuAIeeEe/HW/VsJzzbdnnrWmpvN2HYEf124h2tF+gBrAL0vEgHirfJgX4Ttgu
 L6+RwwQxRvFXclu1MU+oXx0KOPKGs5ARjfyXzYPD0mf7Vbcboy9ZMppF9BtRfF1o
 nYc0f4xtdGbIQvsB1db+tEAFUZHMubP5bN8ZajJKFc5ITceXuTnvLb8duVpM4Bxm
 NKtYVdVd
 =rcEm
 -----END PGP SIGNATURE-----

Merge tag '0.25_rc0'

notmuch 0.25~rc0 release
2017-07-16 09:08:39 -03:00
David Bremner
952a0f0cda debian: note two closed bugs in changelog 2017-07-16 08:49:06 -03:00
David Bremner
f2d3f15770 debian: don't create obsolete bash completion dir 2017-07-16 08:45:55 -03:00
David Bremner
a453f2b52c debian: set distribution to experimental, finalize changelog 2017-07-16 08:35:35 -03:00
David Bremner
d5fedadff4 debian: add more c++ gunk to symbols file 2017-07-16 08:18:19 -03:00
David Bremner
0832fbfca8 debian: bump changelog version, mention SONAME bump 2017-07-16 08:08:18 -03:00
David Bremner
75916f1cc2 NEWS: start entry for 0.25 2017-07-16 08:02:51 -03:00
David Bremner
694e443db5 version: bump version to 0.25~rc0 2017-07-16 08:01:42 -03:00
David Bremner
edb933b25d crypto: clean up unused definitions in gmime 3.0
based on the same patch from dkg as the previous commit.
2017-07-15 21:43:39 -03:00
David Bremner
66c9b11bb0 crypto: Avoid explicit handling of GMimeCryptoContext in gmime 3
gmime 3.0 knows how to select the correct GMimeCryptoContext
automatically, so a bunch of the code in notmuch can be dropped in
that case.

The #ifdef removal of the crypto stuff is better than #define aliasing
in gmime-extra.h for this stuff.  When built against gmime 3.0:

    * it reduces compiled code, and
    * it avoids initializing unused gpgme contexts

(based on a patch from dkg)
2017-07-15 21:43:08 -03:00
David Bremner
606e320e47 cli/crypto: eliminated compiler warnings about unused arguments
These are due to (excessively?) fancy macro definitions in gmime-extra.h
2017-07-15 21:42:49 -03:00
David Bremner
1fdc08d0ff cli/crypto: treat failure to create a crypto context as fatal.
Silently ignoring signed/encrypted parts seems like the wrong idea,
and it also complicates future gmime-3.0 compatibility changes.
2017-07-15 21:39:37 -03:00
David Bremner
f1bcb6b7c2 emacs: change default for notmuch-crypto-process-mime to t
There are some cases like remote usage where this might cause
problems, but those users can easily customize the variable. The
inconvenience seems to be outweighed by the security benefit for most
users.
2017-07-15 09:11:32 -03:00
Tomi Ollila
9fd48b78d0 NEWS: a few formatting updates for 0.24 news items (wiki compatibility)
- removed 7 trailing dots -- to make those lines subsection headers

- converted some (mime type) text to monospace

- removed one extra space
2017-07-15 09:07:17 -03:00
Daniel Kahn Gillmor
f76a245009 clean up use of constants in g_mime_multipart_ wrappers
When compiling as C code (instead of C++) against gmime 3.0, gcc gives
errors like the following:

    error: invalid conversion from ‘int’ to ‘GMimeDecryptFlags’ [-fpermissive]

so use explicit *_NONE values instead.
2017-07-14 21:23:52 -03:00
Daniel Kahn Gillmor
e142de643d config: deprecate/drop crypto.gpg_path under gmime 2.6/3.0
gmime 3.0 no longer offers a means to set the path for gpg.

Users can set $PATH anyway if they want to pick a
differently-installed gpg (e.g. /usr/local/bin/gpg), so this isn't
much of a reduction in functionality.

The one main difference is for people who have tried to use "gpg2" to
make use of gpg 2.1, but that isn't usefully co-installable anyway.
2017-07-14 21:23:52 -03:00
Daniel Kahn Gillmor
8492298a61 Add additional munged reply-to tests
The reply-to munging code might behave differently whether there's an
exact match on the strings or not, or whether the string is a raw
addr-spec instead of an name-addr.  These tests cover those variations
(i also had to tweak json output further below when this new test was
added).
2017-07-14 21:23:52 -03:00
Daniel Kahn Gillmor
23a4d09773 Ensure that "notmuch reply" succeeds during testing.
In some (bad!) cases, "notmuch reply" might fail, or might even
segfault.  If this happens, it indicates a bug, and the test suite
should notice it.
2017-07-14 21:23:52 -03:00
David Bremner
cd853915ec cli: wrap getting uid
Apparently it moved from "name" to "key_id" in gmime-3.0
2017-07-14 21:23:52 -03:00
David Bremner
2b3224a6c4 cli: make keyid from fingerprint in gmime 3.0
The "key_id" field seems to used for userid in gmime-3.0, while the
keyid is dropped in the fingerprint field if the full fingerprint is
not available.
2017-07-14 21:23:52 -03:00
David Bremner
4ce7591610 lib: paper over allocation difference
In gmime 3.0 this function is "transfer none", so no deallocation is
needed (or permitted)
2017-07-14 21:23:52 -03:00
David Bremner
eeb64cdeeb lib: add version of _n_m_f_get_combinded_header for gmime 3.0
The iterator is gone, so we need a new loop structure.
2017-07-14 21:23:52 -03:00
David Bremner
439c5896b6 lib: refactor _notmuch_messsage_file_get_combined_header
We need to rewrite the loop for gmime-3.0; move the loop body to its
own function to avoid code duplication.  Keep the common exit via
"goto DONE" to make this pure code movement.  It's important to note
that the existing exit path only deallocates the iterator.
2017-07-14 21:23:52 -03:00
David Bremner
c040464a7c lib: wrap use of g_mime_utils_header_decode_date
This changes return type in gmime 3.0
2017-07-14 21:23:52 -03:00
David Bremner
fd6e4a9953 cli: hide rename of GMimeCertificateTrust
Both the enum and the values are renamed in GMime 3.0.
2017-07-14 21:23:52 -03:00
David Bremner
c7b9bdb81e cli: generalize use of GMIME_SIGNATURE_{ERROR,STATUS} to gmime-3
The ERROR enum is merged into to the STATUS enum, and the set of flags
is different.
2017-07-14 21:23:52 -03:00
David Bremner
f4a989484f util: fake gmime-2.6 compatible API for gmime-3.0
Several functions have added arguments which accept NULL and provide
hopefully sensible defaults. Use macros to minimize source changes.
2017-07-14 17:58:09 -03:00
David Bremner
32819f74d3 cli: replace use of g_mime_message_get_recipients
This function, and associated enum, have been renamed and generalized
in gmime-3.0.
2017-07-14 17:58:09 -03:00
David Bremner
cbb2d5608e lib/cli: replace use of g_mime_message_get_sender
This function changes semantics in gmime-3.0 so make a new function
that provides the same functionality in both
2017-07-14 17:58:09 -03:00
David Bremner
d7fea36916 cli: replace use of g_mime_message_get_reply_to
This function changes signature in gmime 3.0, so we provide two new
functions, one for each signature.
2017-07-14 17:58:09 -03:00
David Bremner
67dbd24ece cli: replace use of g_mime_message_get_date_as_string
This function goes away in gmime-3.0. Also, the memory management is
apparently error prone, witness the memory leak in notmuch-reply.
2017-07-14 17:58:09 -03:00
David Bremner
a58c75fdf6 test/crypto: mark extra space in userid as a bug in gmime-2.6
I can't see the space in the output of gpg -K --with-colons
2017-07-14 17:58:09 -03:00
David Bremner
a32dd81a55 cli: add space separator for keyword, string, and int arguments
Defer the complication of optional boolean arguments for later (never?).
2017-07-12 17:46:29 -03:00